Change in vdsm[master]: Add validate minimal keys set in dictionaries

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Add validate minimal keys set in dictionaries
......................................................................

Add validate minimal keys set in dictionaries

Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
---
M vdsm/utils.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/540/1
--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 6: Looks good to me, approved

I cannot say that I love this function (too much Edu-cation against "validate"
probably).

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 6: Verified

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Add validate minimal keys set in dictionaries

Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
---
M vdsm/utils.py
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified


--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Add validate minimal keys set in dictionaries
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;