Change in vdsm[master]: BZ#619360 enable and start ntpd

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: BZ#619360 enable and start ntpd
......................................................................

BZ#619360 enable and start ntpd

Vdsm needs to keep host time in sync, or else guest time would lap if
guest is started on a different host. Make sure ntpd is running.

Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
---
M vds_bootstrap/vds_bootstrap.py
M vdsm/vdsmd.init.in
M vdsm/vdsmd.service
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/903/1
--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 3: Verified; Looks good to me, approved

rebased

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2: Looks good to me, approved

Thanks, Douglas!

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#619360 enable and start ntpd
......................................................................


BZ#619360 enable and start ntpd

Vdsm needs to keep host time in sync, or else guest time would lap if
guest is started on a different host. Make sure ntpd is running.

Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
M vdsm/vdsmd.init.in
M vdsm/vdsmd.service
4 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2:

missed the last command from my test report..

# systemctl start vdsmd.service
# systemctl status ntpd.service
<snip>
active (running) <-- from stopped service to started service

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2: Verified

Tests executed:

Test 1
==============
# yum install ./vdsm-4.9.2-0.127.git828e0c6.fc16.x86_64.rpm <others vdsm packages>

Installing:
 vdsm  
 <snip>

Installing for dependencies:
 ntp      <snip>  <--- here
 ntpdate  <snip> 

Test 2
==========
# systemctl stop vdsmd.service
# systemctl stop ntpd.service

# systemctl status ntpd.service
<snip>
inactive (dead) since Tue, 24 Jan 2012 23:34:50 -0500; 5s ago

# systemctl status vdsmd.service
<snip>
inactive (dead) since Tue, 24 Jan 2012 23:34:46 -0500; 13s ago

# systemctl start vdsmd.service
# systemctl status vdsmd.service
<snip>
active (running) since Tue, 24 Jan 2012 23:36:01 -0500; 39s ago

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2:

Itamar, for oVirt, default Fedora/RHEL configuration of ntpd is good enough. If a customer
wants to have his own time source, he could configure /etc/ntp.conf on his own. If there
is a feature request to manage ntpd configuration from oVirt-Engine, I would consider it
in another patch.

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

Itamar Heim has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2:

no need for configuration?

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 1:

correct, Douglas. Would you add this to the patch?

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#619360 enable and start ntpd
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Dan, I do believe we should include to vdsm.spec the ntpd as Requires. Shouldn't we?

--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;