Change in vdsm[master]: hook: checkimages: define GiB properly

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has uploaded a new change for review.

Change subject: hook: checkimages: define GiB properly
......................................................................

hook: checkimages: define GiB properly

The constant is called GIB, but the value was that of the plain decimal
GB.

Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm_hooks/checkimages/before_vm_start.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/79730/1

diff --git a/vdsm_hooks/checkimages/before_vm_start.py
b/vdsm_hooks/checkimages/before_vm_start.py
index e024dd3..31b123d 100755
--- a/vdsm_hooks/checkimages/before_vm_start.py
+++ b/vdsm_hooks/checkimages/before_vm_start.py
@@ -10,7 +10,7 @@
 BLKGETSIZE64 = 0x80081272  # Obtain device size in bytes
 FORMAT = 'L'
 TIMEPERGIB = 0.02  # Approximate qemu-img check time (in seconds) to check 1GiB
-GIB = 10 ** 9  # GiB
+GIB = 2 ** 30  # GiB
 
 '''
 checkimages vdsm hook


-- 
To view, visit https://gerrit.ovirt.org/79730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: hook: checkimages: define GiB properly
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/79730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: hook: checkimages: define GiB properly
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/79730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has submitted this change and it was merged. (
https://gerrit.ovirt.org/79730 )

Change subject: hook: checkimages: define GiB properly
......................................................................


hook: checkimages: define GiB properly

The constant is called GIB, but the value was that of the plain decimal
GB.

Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm_hooks/checkimages/before_vm_start.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Artyom Lukianov: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/79730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96085ece34026dd67158a320b8dff3f9f73be927
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;