Xu He Jie has uploaded a new change for review.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Add synchronous mode for udevTrigger
udevadm trigger was asynchronous. Execute udevadm settle after udevadm trigger, then it can works as synchronous.
Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M vdsm/storage/hsm.py M vdsm/supervdsmServer.py 2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/6916/1 -- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 1:
What's the purpose of this patch? The option '--property-match' can filter the event to be generated. So even it's asynchronous, it should not be a problem.
Please note the problem in http://gerrit.ovirt.org/#/c/6780/ is caused by the race between loading rule and triggering event, not triggering event and running qemu. Please fix me if I am wrong.
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Even just few event, it still have a potential race problem. It also depend on how long will the rules take.
this patch resolve different race problem with http://gerrit.ovirt.org/#/c/6780/. http://gerrit.ovirt.org/#/c/6780/ can fix Bug #844130. This patch try to fix another potential race problem. But I think we should fix it.
.................................................... File vdsm/supervdsmServer.py Line 208: raise OSError(errno.EINVAL, "Could not trigger change for device \ This should be return to caller
Line 213: storage.misc.execCmd(cmd, sudo=False) I should check this return value, if timeout report to caller
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 3:
patchset2: add check for return code of 'udevadm settle' patchset3: update comment message and error message.
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 3: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/247/
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/247/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Royce Lv has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
I test access permission after trigger event, there is some occasion the dev permission's not right, so I believe the trigger action should be synchronized.
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Xu He Jie has abandoned this change.
Change subject: Add synchronous mode for udevTrigger ......................................................................
Patch Set 3: Abandoned
-- To view, visit http://gerrit.ovirt.org/6916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org