Xu He Jie has posted comments on this change.
Change subject: Add synchronous mode for udevTrigger
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Even just few event, it still have a potential race problem. It also depend on how long
will the rules take.
this patch resolve different race problem with
http://gerrit.ovirt.org/#/c/6780/.
http://gerrit.ovirt.org/#/c/6780/ can fix Bug #844130. This patch try to fix another
potential race problem. But I think we should fix it.
....................................................
File vdsm/supervdsmServer.py
Line 208: raise OSError(errno.EINVAL, "Could not trigger change for
device \
This should be return to caller
Line 213: storage.misc.execCmd(cmd, sudo=False)
I should check this return value, if timeout report to caller
--
To view, visit
http://gerrit.ovirt.org/6916
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I731c3ef6fe945c7c0278d638bf4cc8164345fd01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>