Change in vdsm[master]: iscsi: fix update discoverydb with wrong key

[Xu He Jie]

Xu He Jie has uploaded a new change for review.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................

iscsi: fix update discoverydb with wrong key

When execute discoverSendTargets will get errror message:

Thread-15::DEBUG::2012-07-10 10:44:32,384::__init__::1249::Storage.Misc.excCmd::(_log)
'/usr/bin/sudo -n /usr/sbin/iscsiadm -m discoverydb -t sendtargets -I default -p
192.168.122.89:3260 -n node.startup -v manual --op=update' (cwd None)
Thread-15::DEBUG::2012-07-10 10:44:32,404::__init__::1249::Storage.Misc.excCmd::(_log)
FAILED: <err> = 'iscsiadm: Cannot modify node.startup. Invalid param
name.\n'; <rc> = 7

We should set discovery.startup when discover targets.

Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Signed-off-by: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
---
M vdsm/storage/iscsi.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/6092/1
--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/195/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/195/

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1:

Mark, yes, it dones't used by iscsiadm. But as the comment in the code, I guess we
prefer to keep this for ensure this won't break in the future when iscsiadm support
that.

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

Mark Wu has posted comments on this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I prefer to remove the following code:
iscsiadm.discoverydb_update(discoverType, iface.name, portalStr, "node.startup",
"manual")

Becuase the 'discovery.startup' is set to 'manual' by default in iscsiadm.
And it's not actively used by iscsiadm. So we don't need to set it here.

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;

[Xu He Jie]

Xu He Jie has abandoned this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server