Change in vdsm[master]: spec: declare mkimageTests' requirement of genisoimage

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

spec: declare mkimageTests' requirement of genisoimage

Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Signed-off-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/7674/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0d1b195..9e461e0 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -34,6 +34,7 @@
 BuildRequires: python-ethtool
 BuildRequires: libvirt-python
 BuildRequires: sanlock-python >= 2.3
+BuildRequires: genisoimage

%if !0%{?rhel}
 BuildRequires: systemd-units

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/810/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

Patch Set 1: Verified

Run through autobuild.sh
Then I remove genisoimage from my system and rpmbuild -bb vdsm.spec. It reports the genisoimage dependency missing as expected.

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: declare mkimageTests' requirement of genisoimage
......................................................................

spec: declare mkimageTests' requirement of genisoimage

Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Signed-off-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebdfee2c57c62bb5c13608b86e468435e921eb88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server