Change in vdsm[master]: pylint:vdsm/netinfo.py rename nics() function to avoid overl...

[Ryan Harper]

Ryan Harper has uploaded a new change for review.

Change subject: pylint:vdsm/netinfo.py rename nics() function to avoid overload with local
variable
......................................................................

pylint:vdsm/netinfo.py rename nics() function to avoid overload with local variable

************* Module netinfo
E:377:NetInfo.getNicsVlanAndBondingForNetwork: Function 'nics' has no
'append' member

The global function nics() is confusion pylint with the local 'nics' list;
remedy this by renaming the function.

Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com&gt;
---
M vdsm/netinfo.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/3445/1
--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;

Change in vdsm[master]: pylint:vdsm/netinfo.py rename local vars to avoid overload w...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pylint:vdsm/netinfo.py rename local vars to avoid overload with global
func.
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pylint:vdsm/netinfo.py rename nics() function to avoid overload with local
variable
......................................................................


Patch Set 2: I would prefer that you didn't submit this

netinfo.nics() is used in clientIF.

this patch breaks a symmetry with the bridges(), vlans() functions etc. How about changing
the name of the local variable instead?

--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: pylint:vdsm/netinfo.py rename nics() function to avoid overload with local
variable
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netinfo.py
Line 40: def enumerate_nics():
we use mixedCase in VDSM

--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: pylint:vdsm/netinfo.py rename local vars to avoid overload w...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: pylint:vdsm/netinfo.py rename local vars to avoid overload with global
func.
......................................................................


pylint:vdsm/netinfo.py rename local vars to avoid overload with global func.

************* Module netinfo
E:377:NetInfo.getNicsVlanAndBondingForNetwork: Function 'nics' has no
'append' member

The global function nics() is confusion pylint with the local 'nics' list;
remedy this by renaming the local variables.

V2->V3
    - change the local vars instead of global func
V1->V2
    - change function name to use mixedCaps

Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com&gt;
---
M vdsm/netinfo.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: pylint:vdsm/netinfo.py rename local vars to avoid overload w...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: pylint:vdsm/netinfo.py rename local vars to avoid overload with global
func.
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/3445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;