Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] The begining of the new API ......................................................................
[WIP] The begining of the new API
Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 --- M vdsm/storage/hsm.py 1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/1695/1 -- To view, visit http://gerrit.ovirt.org/1695 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: New connection management API ......................................................................
Patch Set 4: (1 inline comment)
Partially reviewed.
Maybe we can pass to storageServer_ConnectionRefs_statuses() single connection refID to get status for this connection only.
.................................................... File vdsm/storage/storageServer.py Line 563: for conId, con in self._conDict.items(): why this unnecessary copy?
-- To view, visit http://gerrit.ovirt.org/1695 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: New connection management API ......................................................................
Patch Set 12: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1695 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: New connection management API ......................................................................
New connection management API
Connection are no longer managed directly. A client uses references to the actual connection and VDSM manages the actuall lifcycle of the objects.
More information at http://www.ovirt.org/wiki/Features/ConnectionReferences
Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/storageServer.py M vdsm/storage/storage_exception.py 5 files changed, 241 insertions(+), 37 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1695 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org