10:10 a.m.
Ryan Harper has uploaded a new change for review.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Remove rhevm from vds_bootstrap/
sed -e 's,RHEVM,OVIRT,g' -e 's,RHEV,oVirt,g'
Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_bootstrap_complete.py
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/3287/1
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
10:56 a.m.
Adam Litke has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
Make sure that renaming the component doesn't break ovirt-engine.
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
This may require changes to ovirt-engine so that it can properly recognize the new
component name.
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
2:27 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
... and for backward compatibility, we would have to use the RHEV strings easily.
the original code does not satisfy the "thou shall not write a string twice"
commandment, but I would have to ask you to take some of the silly repetitiveness from
it.
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
11:53 a.m.
Ryan Harper has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
Let's talk about the backward compat... Are you expecting an upstream version of vdsm
to run with an older version/non-ovirt engine?
or maybe a better question is, what program consumes these strings and what actions do
they take? If vdsm changed it's strings to OVIRT_INSTALL, wouldn't the compat be
handled in the consumer?
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
2:56 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
We have customers with downstream Engine installed. If downstream vdsm-bootstrap includes
your change as-is, host installation would fail. Old downstream Engine expects
RHEV_INSTALL. This means that in order to work with it, downstream vdsm would have to undo
your patch(es).
We could theoretically force the customer to upgrade to a newer Engine, with a smarter
logic. However, customers don't like to be forced (and breaking API is evil). Also,
someone would have to add logic to new Engine (I don't expect that you've sent a
compatible patch to Engine, right?)
Now since I don't want RHEV trademarks cluttering vdsm code, I appreciate your help in
their removal - but I'd politely ask you to make it easier for us to revert the
API-breaking ones downstream.
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
9:30 a.m.
Ryan Harper has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
Why would downstream (distro) vdsm-bootstrap include these upstream bits? Would you also
update vdsm without also updating RHEVM? Wouldn't we modify RHEVM/engine to support
either string? It would consider the RHEV_INSTALL string as legacy and I don't see
any reason it couldn't support the OVIRT_INSTALL string as well.
Textstrings don't make an robust API; we're just both saying that this element
needs to be more robust. To be fair, I've not read the counterpart-code in engine yet
to see why it's doing string parsing during this procedure. I'll go take a look
at that part today.
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
5:34 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926: print "<BSTRAP component='OVIRT_INSTALL'
status='FAIL'/>"
being somewhat related to the downstream build process, I would like to keep it as close
to upstream. I'd like to have as few and as simple downstream-only patches as
possible.
Yes, it is possible to add a compatible patch to Engine, and to have this patch include a
Conflicts: engine < whatever-version-you-get-your-patch-into. This would disable an
update of vdsm-bootsrap without a compatible update of ovirt-engine.
Doing the above is more complex (but preferable in my perspective) than making it easy to
reproduce legacy behavior in vdsm-bootstrap.
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
10:20 a.m.
Ryan Harper has abandoned this change.
Change subject: Remove rhevm from vds_bootstrap/
......................................................................
Patch Set 1: Abandoned
Too Old
--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4139
days inactive
4413
days old
vdsm-patches@lists.fedorahosted.org
7 comments
3 participants
participants (3)
-
agl＠us.ibm.com -
Dan Kenigsberg -
Ryan Harper