Royce Lv has uploaded a new change for review.
Change subject: Exclude generated python files from pep8 list ......................................................................
Exclude generated python files from pep8 list
Generated files will raise pep8 error because of path substitution: E501 line too long (86 characters) Check the py.in for PEP8 is enough for these files.
Change-Id: I73470d5587adec539163b352a02d99909305a1e4 Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/9675/1
diff --git a/Makefile.am b/Makefile.am index 489eb6b..99e1a4f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -98,7 +98,7 @@ vdsm_reg/define.py \ $(NULL)
-PEP8_BLACKLIST = apiData.py +PEP8_BLACKLIST = apiData.py,config.py,constants.py
check-local: find . -path './.git' -prune -type f -o \
-- To view, visit http://gerrit.ovirt.org/9675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I73470d5587adec539163b352a02d99909305a1e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Exclude generated python files from pep8 list ......................................................................
Exclude generated python files from pep8 list
Generated files will raise pep8 error because of path substitution: E501 line too long (86 characters) Check the py.in for PEP8 is enough for these files.
Change-Id: I73470d5587adec539163b352a02d99909305a1e4 Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I73470d5587adec539163b352a02d99909305a1e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Exclude generated python files from pep8 list ......................................................................
Patch Set 1: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73470d5587adec539163b352a02d99909305a1e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
vdsm-patches@lists.fedorahosted.org