Change in vdsm[master]: make vdsm_reg/createDaemon.py PEP8 clean

Hello Bing Bu Cao,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/5417

to review the following change.

Change subject: make vdsm_reg/createDaemon.py PEP8 clean
......................................................................

make vdsm_reg/createDaemon.py PEP8 clean

Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Signed-off-by: Cao,Bing Bu <mars(a)linux.vnet.ibm.com&gt;
---
M Makefile.am
M vdsm_reg/createDaemon.py
2 files changed, 150 insertions(+), 138 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/5417/1
--
To view, visit http://gerrit.ovirt.org/5417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: make vdsm_reg/createDaemon.py PEP8 clean
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/5417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: make vdsm_reg/createDaemon.py PEP8 clean
......................................................................


make vdsm_reg/createDaemon.py PEP8 clean

Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Signed-off-by: Cao,Bing Bu <mars(a)linux.vnet.ibm.com&gt;
---
M Makefile.am
M vdsm_reg/createDaemon.py
2 files changed, 150 insertions(+), 138 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/5417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm_reg/createDaemon.py PEP8 clean
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/5417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;

Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm_reg/createDaemon.py PEP8 clean
......................................................................


Patch Set 1: Verified

Passes tests in vdsm.
pydiff reports 4 changes, but all of them are changing 
"raise Exception, stringMessage" 
to 
"raise Exception(stringMessage)" 
so these changes are acceptable.


pydiff detailed report is as follow:
pydiff createDaemon*.py
4 difference(s)
first file: createDaemono.py
second file: createDaemon.py

((60, "Name('Exception')"),
 (62,
  "CallFunc(Name('Exception'), [Mod((Const('%s [%d]'),
Tuple([Getattr(Name('e'), 'strerror'), Getattr(Name('e'),
'errno')])))], None, None)"))

((60,
  Mod((Const('%s [%d]'), Tuple([Getattr(Name('e'), 'strerror'),
Getattr(Name('e'), 'errno')])))),
 (62, None))

((108, "Name('Exception')"),
 (118,
  "CallFunc(Name('Exception'), [Mod((Const('%s [%d]'),
Tuple([Getattr(Name('e'), 'strerror'), Getattr(Name('e'),
'errno')])))], None, None)"))

((108,
  Mod((Const('%s [%d]'), Tuple([Getattr(Name('e'), 'strerror'),
Getattr(Name('e'), 'errno')])))),
 (118, None))


The first two reported changes in line 60 are about changing 
"raise Exception, "%s [%d]" % (e.strerror, e.errno)"
to 
"raise Exception("%s [%d]" % (e.strerror, e.errno))"
The rest reported changes are the same kind.

--
To view, visit http://gerrit.ovirt.org/5417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f6708e2b3e203610e0fbbaad90ad8467cda3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt;