Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions" ......................................................................
Revert "BZ#708779 - Avoid pools with mixed domain versions"
This reverts commit 017db3b2740a8c7d22c5366c70600eb47643e8ab.
We would like to allow upgrading a storage pool to new 3.0 format, and to allow upgrading 2.2 domains automatically when they are attached to a 3.0-formatted pool.
Conflicts:
vdsm/storage/hsm.py vdsm/storage/sp.py
Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 --- M vdsm/storage/hsm.py M vdsm/storage/sp.py M vdsm/storage/storage_exception.py 3 files changed, 12 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/753/1 -- To view, visit http://gerrit.ovirt.org/753 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions" ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/storage_exception.py Line 728: #removed in 3.0.2 Leave it uncommented, if it's commented the check for duplicate IDs will not catch this. The whole point of leaving this in the file is so it does.
-- To view, visit http://gerrit.ovirt.org/753 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has abandoned this change.
Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions" ......................................................................
Patch Set 1: Abandoned
time to abandon this. sd upgrade is going to be handled much more seriously by http://gerrit.ovirt.org/#/c/2441/ and its friends.
-- To view, visit http://gerrit.ovirt.org/753 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org