Change in vdsm[master]: Add sanlock-python to the BuildRequires

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add sanlock-python to the BuildRequires
......................................................................

Add sanlock-python to the BuildRequires

Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Change-Id: I7804895173107746724187eb56dbe78204e21fcf
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/5581/1
--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add sanlock-python to the BuildRequires
......................................................................


Add sanlock-python to the BuildRequires

Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Change-Id: I7804895173107746724187eb56dbe78204e21fcf
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add sanlock-python to the BuildRequires
......................................................................


Patch Set 1:

now that http://jenkins.ovirt.org/computer/fedora_17_slave_02 has it, we can require
sanlock-python explicitly.

--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add sanlock-python to the BuildRequires
......................................................................


Patch Set 1:

I meant that the slaves do not have sanlock-python yet (do you know why, Eyal?)

--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add sanlock-python to the BuildRequires
......................................................................


Patch Set 1: Verified; Looks good to me, approved

I'm intentionally not pushing this in, since our jenkins slaves do not have sanlock
yet, and this requirement would make *all* unit tests fail.

--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add sanlock-python to the BuildRequires
......................................................................


Patch Set 1:

>  I'm intentionally not pushing this in, since our jenkins slaves
> do not have sanlock yet, and this requirement would make *all* unit tests fail. 
Are you sure about this? You just need the sanlock-python package to import the module.
The daemon isn't actually required.

--
To view, visit http://gerrit.ovirt.org/5581
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7804895173107746724187eb56dbe78204e21fcf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;