Ryan Harper has posted comments on this change.
Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1328: def cpuHypervisorID():
Line 1329: # we cannot (yet) use _cpuid because of the different
Line 1330: # unpack format.
Line 1331: HYPERVISOR_CPUID_LEAF = 0x40000000
Line 1332: with open('/dev/cpu/0/cpuid') as f:
This file is provided by the kernel if:
CONFIG_X86_MSR=y
in RHEL6 it's currently part of the kernel config. Other distros might not have this
compiled in. It may be a module. I'd like to see if we can be robust here and either
have deployUtil attempt to load the module or something else so we don't fail on
systems that are configured slightly different.
Thoughts?
Line 1333: f.seek(HYPERVISOR_CPUID_LEAF)
Line 1334: c = struct.unpack('I12s', f.read(16))
Line 1335: return c[1].strip('\x00')
Line 1336:
--
To view, visit
http://gerrit.ovirt.org/7657
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server