Change in vdsm[master]: engine.py: fix nodeCleanup() order call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................

engine.py: fix nodeCleanup() order call

Call deployUtil.nodeCleanup() only if oVirt Engine is reachable.
Even if oVirt Engine is not reachable it will backup cacert.pem and remove it.
However, since we cannot reach the Engine won't be possible to download the new
cacert.pem and TUI will break next time someone try to register oVirt Engine.

Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm_reg/engine.py.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/6859/1
--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has abandoned this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: Abandoned

Get deprecated by: http://gerrit.ovirt.org/#/c/8038/

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
So I don't really understand what is different in this regard. The only change I would
still like to do is store temp file and then move to destination as procedure for updating
files.
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: I would prefer that you didn't submit this

I will provide new version.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

Mark Wu has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4:

Douglas,
I have two questions:
1. why do we try to avoid overriding the old cert. it seems related to bz741856, but I
can't access it.

2. How about restoring the old cert if the new cert is not available, invalid or failed to
persist?

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
Hi Dan, can we get this patch since Juan's patch has been merged: (Validate downloaded
CA certificate) ?
http://gerrit.ovirt.org/#/c/8021/

It's important fix for node side. 

Thanks
Douglas
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
frankly, *I* was asking if you are fine with this problem... It does not mean the
end-of-the-world to me.

But yes, in my opinion, this function is all wrong. The caller should receive the cert
string, verify it, do the backups, and only finally persist the new cert. There is no
point in writing down a cert that has the wrong fingerprint.
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
Dan, can you please clarify to me: Do you prefer download the cert with a different name
and after that remove/unpersist the current cert and rename the downloaded cert to
cacert?
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
there is still a chance that we die here, and loose everything - the old cert and the new
one. are we fine with this?
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/554/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 3: I would prefer that you didn't submit this

thanks for the re-write. I think we still have a problem if getRhevmCert fails, or if the
fingerprint is rejected. Could we somehow do the cleanup only after we have the new cert?

If it is too complex, a #TODO will do.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 13: cacert.pem and TUI will break next time someone try to register oVirt Engine.
sorry, I still have problems parsing the English...

what do you describe here, the current state? or the state after the patch? Could you
start the paragraph with the current buggy behavior, then say how it is solved?

(I truly do not understand...)

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 12: cacert.pem and TUI will break next time someone try to register oVirt Engine.
so why not clean the node only after a new certificate has been received?

it's not a real -1, you can provide an explanation in the commit message if you
consider the code as correct.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Yaniv Bronhaim has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

seems like bug fix. if the pem files will be deleted, and nodeCleanup() fails and returns
False afterwards, it can causes unwanted flow.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 1: Verified

IMO, it should go to ovirt 3.1 branch as well.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com&gt;