Dan Kenigsberg has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() order call
......................................................................
Patch Set 3: I would prefer that you didn't submit this
thanks for the re-write. I think we still have a problem if getRhevmCert fails, or if the
fingerprint is rejected. Could we somehow do the cleanup only after we have the new cert?
If it is too complex, a #TODO will do.
--
To view, visit
http://gerrit.ovirt.org/6859
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>