10:36 a.m.
Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32061
to review the following change.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
tool: Fix TypeError when configuration check fails
When is-configured and validate-config failed for some modules, we got a
TypeError trying to join a list of configurator objects, instead of list
of strings.
TypeError: sequence item 0: expected string, Sanlock found
Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31782
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/32061/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index b799fde..83e7d41 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -97,7 +97,8 @@
ret = True
args = _parse_args(*args)
- m = [c for c in args.modules if c.isconfigured() == NOT_CONFIGURED]
+ m = [c.getName() for c in args.modules
+ if c.isconfigured() == NOT_CONFIGURED]
if m:
sys.stdout.write(
@@ -131,7 +132,7 @@
ret = True
args = _parse_args(*args)
- m = [c for c in args.modules if not c.validate()]
+ m = [c.getName() for c in args.modules if not c.validate()]
if m:
sys.stdout.write(
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
5:26 p.m.
Nir Soffer has posted comments on this change.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:12 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
6:01 a.m.
mooli tayer has posted comments on this change.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
4:25 p.m.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
tool: Fix TypeError when configuration check fails
When is-configured and validate-config failed for some modules, we got a
TypeError trying to join a list of configurator objects, instead of list
of strings.
TypeError: sequence item 0: expected string, Sanlock found
Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127877
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31782
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32061
Tested-by: mooli tayer <mtayer(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, approved
mooli tayer: Verified
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
4:53 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: Fix TypeError when configuration check fails
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/119/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fde1ddbbb9584429a4c190d38a2817e5a6dfb1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3548
days inactive
3553
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
Jenkins CI RO -
mtayer＠redhat.com -
Nir Soffer -
ybronhei＠redhat.com