Change in vdsm[master]: (Schema) Change BlockDevicePathInfo so that it needs one les...

Saggi Mizrahi has uploaded a new change for review.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

(Schema) Change BlockDevicePathInfo so that it needs one less redundant enum

Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Signed-off-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 6 insertions(+), 18 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/6843/1
--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 832: #               failed.
I think this is a good idea but it represents a divergence from today's behavior.  How are we going to track that deviation so that we can account for it when we write the server-side bindings to the internal vdsm code?

--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli

Adam Litke has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 907:  'data': {'physdev': 'str', 'active': 'bool',
Just noticed that the documentation comment and the symbol definition do not agree on the name of the stateActive member.

--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/438/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/6843
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab262a1fbadf89aec0c649822a2a5879823521d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Patch Set 5:

ping?

Itamar Heim has abandoned this change.

Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
......................................................................

Abandoned

no reply - abandoning - please restore if still relevant