Change in vdsm[master]: vm: reformat _EVENT_STRINGS

Francesco Romani has uploaded a new change for review.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................

vm: reformat _EVENT_STRINGS

Reformat code to make it easy to extend the known event list.

Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Format-Only: yes
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/48530/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f9bc25c..7dd0247 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -158,14 +158,16 @@
 
 # These strings are representing libvirt virDomainEventType values
 # http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventType
-_EVENT_STRINGS = ("Defined",
-                  "Undefined",
-                  "Started",
-                  "Suspended",
-                  "Resumed",
-                  "Stopped",
-                  "Shutdown",
-                  "PM-Suspended")
+_EVENT_STRINGS = (
+    "Defined",
+    "Undefined",
+    "Started",
+    "Suspended",
+    "Resumed",
+    "Stopped",
+    "Shutdown",
+    "PM-Suspended",
+)
 
 
 def eventToString(event):


-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................


Patch Set 1: Verified+1

trivial patch, verified by tests.

-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................


vm: reformat _EVENT_STRINGS

Reformat code to make it easy to extend the known event list.

Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Format-Only: yes
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/48530
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No