Change in vdsm[master]: Re-organized internal network APIs in API bridge

Adam Litke has posted comments on this change.

Change subject: Re-organized internal network APIs in API bridge
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

Just some general naming changes in addition to Dan's suggestion.

....................................................
File vdsm/API.py
Line 930:         """Add a new network to this vds.
Since this is already in a class called Network, the function can be named simply:
'add'.

Line 959:         """Delete a network from this vds."""
name this one 'delete'

Line 997:                     nics=None, options={}):
Name this one 'edit'

Line 1023:         """Add a new network to this vds, replacing an old
one."""
You can name this one 'setup'.

Line 1186
Can you move this one into the Network class too please?

--
To view, visit http://gerrit.ovirt.org/2663
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64771991c3db09247f7689e6b5ddffa8adbf6745
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;