Adam Litke has posted comments on this change.
Change subject: Add function getNetworkList to API bridge
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Dan: Bindings are not allowed to call into vdsm internal functions. They must only call
into API.py. Therefore, if we want a listNetworks API to be exposed, we must add the
appropriate call to API.py (even if BindingXMLRPC chooses not to expose it).
....................................................
File vdsm/API.py
Line 1209: print "Networks:", networkList
Li Lei, don't forget to remove this debug statement in the next patch series.
--
To view, visit
http://gerrit.ovirt.org/2664
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>