Saggi Mizrahi has uploaded a new change for review.
Change subject: Happy new year hsm.py ......................................................................
Happy new year hsm.py
Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/1690/1 -- To view, visit http://gerrit.ovirt.org/1690 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Happy new year hsm.py ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1690 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Happy new year hsm.py ......................................................................
Patch Set 1: Looks good to me, approved
We should do it on all vdsm files
-- To view, visit http://gerrit.ovirt.org/1690 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Happy new year hsm.py ......................................................................
Patch Set 1: Verified; Looks good to me, approved
it makes very little sense to have a special patch like that. A year change should accompany a patch with an actual change to the file.
but I'm to tired to argue about nonsense with you.
-- To view, visit http://gerrit.ovirt.org/1690 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Happy new year hsm.py ......................................................................
Happy new year hsm.py
Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1690 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Icbd8843c6a839a6db6131a422005c104f173886d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org