Dan Kenigsberg has uploaded a new change for review.
Change subject: Fix two regressions introduced by the API.py refactoring ......................................................................
Fix two regressions introduced by the API.py refactoring
The recovery code is left a serious need of refactoring. At least it is working now.
Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 --- M vdsm/BindingXMLRPC.py M vdsm/clientIF.py 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/1610/1 -- To view, visit http://gerrit.ovirt.org/1610 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Fix two regressions introduced by the API.py refactoring ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1610 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Fix two regressions introduced by the API.py refactoring ......................................................................
Patch Set 1: Looks good to me, approved
Unfortunately this patch is a necessary hack. Agreed with Dan's commit message. The recovery flow should be rewritten.
-- To view, visit http://gerrit.ovirt.org/1610 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix two regressions introduced by the API.py refactoring ......................................................................
Fix two regressions introduced by the API.py refactoring
The recovery code is left a serious need of refactoring. At least it is working now.
Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 --- M vdsm/BindingXMLRPC.py M vdsm/clientIF.py 2 files changed, 3 insertions(+), 2 deletions(-)
Approvals: Dan Kenigsberg: Verified Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1610 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org