Igor Lvovsky has uploaded a new change for review.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Add hotplugNic/hotunplugNic feature to vdsClient.
Usage: vdsClient 0 hotplugNic|hotunplugNic vmUUID <nicspec>
'nicspec parameters list: r=required, o=optional', 'r device: bridge|sriov|vnlink|bridgeless.', 'r network: network name', 'r macAddr: mac address', 'r nicModel: pv|rtl8139|e1000', 'o bootOrder: <int> - global boot order across all bootable devices'
Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a --- M vdsm_cli/vdsClient.py 1 file changed, 34 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/1367/1 -- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Patch Set 4: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add hotplugNic/hotunplugNic feature to vdsClient. ......................................................................
Add hotplugNic/hotunplugNic feature to vdsClient.
Usage: vdsClient 0 hotplugNic|hotunplugNic vmUUID <nicspec>
'nicspec parameters list: r=required, o=optional', 'r device: bridge|sriov|vnlink|bridgeless.', 'r network: network name', 'r macAddr: mac address', 'r nicModel: pv|rtl8139|e1000', 'o bootOrder: <int> - global boot order across all bootable devices'
Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a --- M vdsm_cli/vdsClient.py 1 file changed, 34 insertions(+), 2 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Verified
-- To view, visit http://gerrit.ovirt.org/1367 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I6fc79eeddabbe8bd7c82a026964f85d02ab8f56a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org