Ayal Baron has posted comments on this change.
Change subject: Use SANLock for the SPM resource
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(7 inline comments)
....................................................
File vdsm/storage/blockVolume.py
Line 240: cls.newVolumeLease(sdUUID, volUUID, offs)
The previous line marks the volume as 'legal' effectively committing the operation
so I believe the volume lease should be initialized before writing the MD.
....................................................
File vdsm/storage/fileVolume.py
Line 193: cls.newVolumeLease(sdUUID, volUUID, vol_path)
Same as in block (should come before newMetadata
Line 212: vol_path = self.getVolumePath()
You can change vol_path to volPath for consistency
Line 213: lease_path = self.__leaseVolumePath(vol_path)
why is this here and not down where you actually use it?
Line 547: return None
why do we support vol_path being empty?
why is the variable not named volPath?
....................................................
File vdsm/storage/sd.py
Line 102: DOM_SAFELEASE_VERS = (0,2)
If 3 doesn't support safelease then how do you do the transition without stopping
everything?
Line 400: def hasVolumeLeases(self):
'has' is not really the right word here.
'supports' maybe.
But I would rather see a capabilities dictionary or something and test against that, so
that we'd have a generic way for checking capabilities.
--
To view, visit
http://gerrit.ovirt.org/726
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>