Change in vdsm[master]: image: use qemu-img convert to copy internal volumes

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................

image: use qemu-img convert to copy internal volumes

According to the qemu-img manual:

 You can use the backing_file option to force the output image to be
 created as a copy on write image of the specified base image; the
 backing_file should have the same content as the input's base image,
 however the path, image format, etc may differ.

The benefits to use qemu-img convert instead of dd to copy the internal
volumes are:

- we unify operations under just one tool that is specific for image
  manipulations

- copying images from block domains we won't copy the entire chunk
  (1Gb) but only the amount of data really in use

The downside is the additional call to getParentVolume (that seems
trascurable compared to the amount of data that we're going to copy).

Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 18 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/33355/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 9855a26..306722b 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -430,21 +430,25 @@
                 try:
                     dstVol = destDom.produceVolume(imgUUID=imgUUID,
                                                    volUUID=srcVol.volUUID)
-                    srcFmt = srcVol.getFormat()
-                    if srcFmt == volume.RAW_FORMAT:
-                        srcFmtStr = volume.fmt2str(srcFmt)
-                        dstFmtStr = volume.fmt2str(dstVol.getFormat())
-                        self.log.debug("start qemu convert")
-                        qemuimg.convert(srcVol.getVolumePath(),
-                                        dstVol.getVolumePath(),
-                                        vars.task.aborting,
-                                        srcFmtStr, dstFmtStr)
+                    srcFmtStr = volume.fmt2str(srcVol.getFormat())
+                    dstFmtStr = volume.fmt2str(dstVol.getFormat())
+
+                    pntVol = dstVol.getParentVolume()
+
+                    if pntVol is not None:
+                        pntBakPath = volume.getBackingVolumePath(
+                            imgUUID, pntVol.volUUID)
+                        pntFmtStr = volume.fmt2str(pntVol.getFormat())
                     else:
-                        srcSize = srcVol.getVolumeSize(bs=1)
-                        misc.ddWatchCopy(srcVol.getVolumePath(),
-                                         dstVol.getVolumePath(),
-                                         vars.task.aborting,
-                                         size=srcSize)
+                        pntBakPath = None
+                        pntFmtStr = None
+
+                    self.log.debug("start qemu convert")
+                    qemuimg.convert(srcVol.getVolumePath(),
+                                    dstVol.getVolumePath(),
+                                    vars.task.aborting,
+                                    srcFmtStr, dstFmtStr,
+                                    pntBakPath, pntFmtStr)
                 except ActionStopped:
                     raise
                 except se.StorageException:


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11630/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12574/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12419/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 1:

(2 comments)

Great idea, need some cleanup.

http://gerrit.ovirt.org/#/c/33355/1/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFmtStr = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFmtStr = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
srcFmtStr? pntVol? This is too cryptic for me :-)

Lets use nicer names, and when possible, the same names used in qemuimg.convert():

  parentVol
  srcFormat
  dstFormat
  backingFile
  backingFormat
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         pntBakPath = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


Line 447:                     qemuimg.convert(srcVol.getVolumePath(),
Line 448:                                     dstVol.getVolumePath(),
Line 449:                                     vars.task.aborting,
Line 450:                                     srcFmtStr, dstFmtStr,
Line 451:                                     pntBakPath, pntFmtStr)
There are 2 sins here:
- Mixing one parameter per line with multiple parameters
- Calling kwargs arguments like positional args
Line 452:                 except ActionStopped:
Line 453:                     raise
Line 454:                 except se.StorageException:
Line 455:                     self.log.error("Unexpected error", exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/1//COMMIT_MSG
Commit Message:

Line 22: - copying images from block domains we won't copy the entire chunk
Line 23:   (1Gb) but only the amount of data really in use
Line 24: 
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
The downside is insignificant - we can remove this sentence from the commit message.

The real downside is this can breaks everything if qemu-img convert with backing file is
buggy - we never used this option - right?
Line 27: 
Line 28: Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12824/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11876/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12667/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/2//COMMIT_MSG
Commit Message:

Line 23:   (1Gb) but only the amount of data really in use
Line 24: 
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
Line 27: 
https://bugzilla.redhat.com/show_bug.cgi?id=1156115
Line 28: Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/2/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
Would you rename "pnt" to "parent"?
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         backing = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13389/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12599/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/165/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13551/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 3:

(1 comment)

Nice one, added only comment(s) for possible readability improvements

http://gerrit.ovirt.org/#/c/33355/3/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
maybe 'parentVolume' is more readable?
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         backing = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.ovirt.org/#/c/33355/3//COMMIT_MSG
Commit Message:

Line 10: 
Line 11:  You can use the backing_file option to force the output image to be
Line 12:  created as a copy on write image of the specified base image; the
Line 13:  backing_file should have the same content as the input's base image,
Line 14:  however the path, image format, etc may differ.
Does this create dependency between unrelated volumes?
Line 15: 
Line 16: The benefits to use qemu-img convert instead of dd to copy the internal
Line 17: volumes are:
Line 18: 


Line 19: - we unify operations under just one tool that is specific for image
Line 20:   manipulations
Line 21: 
Line 22: - copying images from block domains we won't copy the entire chunk
Line 23:   (1Gb) but only the amount of data really in use
But if volumes are big, copying with dd is faster, at least to NFS:
https://bugzilla.redhat.com/show_bug.cgi?id=1132219
Line 24: 
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
Line 27: 


Line 23:   (1Gb) but only the amount of data really in use
Line 24: 
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
Line 27: 
Bug-Url? see http://gerrit.ovirt.org/#/c/33355/2//COMMIT_MSG
Line 28: Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c


http://gerrit.ovirt.org/#/c/33355/3/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
>  maybe 'parentVolume' is more readable? 
Or parentVol as
I suggested in the previous patch
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         backing = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13569/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14526/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14358/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 4:

Looks good, but I'm worried that this will not perform better, due to
https://bugzilla.redhat.com/1132219

Would be nice to see some timings or typical operations comparing old and new code.

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

automation(a)ovirt.org has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 5:

* Update tracker::#1156115::OK
* Check Bug-Url::OK
* Check Public Bug::#1156115::OK, public bug
* Check Product::#1156115::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15282/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15113/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14325/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.ovirt.org/#/c/33355/5//COMMIT_MSG
Commit Message:

Line 33:  coreutils-8.4-37.el6.x86_64
Line 34:  kernel-2.6.32-504.1.3.el6.x86_64
Line 35:  qemu-img-rhev-0.12.1.2-2.415.el6_5.3.x86_64
Line 36: 
Line 37: - dd 3Gb data volume on block domain: 67.16s +-2.19s [1]
What about other options - from file to block, from block to file, from file to file?

What is 67.16s - average? of how many runs?
What is +-2.19s - stddev?
Line 38: - qemu-img 2Gb data volume on block domain: 37.60s +-0.32s
Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s


Line 37: - dd 3Gb data volume on block domain: 67.16s +-2.19s [1]
Line 38: - qemu-img 2Gb data volume on block domain: 37.60s +-0.32s
Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s
Why qemu-img is faster - copying only allocated blocks?
Line 42: 
Line 43: All the volumes contained the same (u)random data.
Line 44: 
Line 45: [1] here dd pays the price of having to copy the entire chunk of


Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s
Line 42: 
Line 43: All the volumes contained the same (u)random data.
Is this typical? I think we should test typical volume - for example, system after clean
install and yum update.
Line 44: 
Line 45: [1] here dd pays the price of having to copy the entire chunk of
Line 46:     allocated space (3Gb vs 2Gb of real data). Anyway even when
Line 47:     normalized to the same amount of data it's still slower.


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.ovirt.org/#/c/33355/5//COMMIT_MSG
Commit Message:

Line 33:  coreutils-8.4-37.el6.x86_64
Line 34:  kernel-2.6.32-504.1.3.el6.x86_64
Line 35:  qemu-img-rhev-0.12.1.2-2.415.el6_5.3.x86_64
Line 36: 
Line 37: - dd 3Gb data volume on block domain: 67.16s +-2.19s [1]
>  What about other options - from file to block, from block to file,
> from fil 
The stats from file to file are below.

Data are average on 5 runs and stddev.

Other combinations, e.g. block to file and file to block are irrelevant because we already
proved that writing to block and writing to file is faster with qemu-img.
Line 38: - qemu-img 2Gb data volume on block domain: 37.60s +-0.32s
Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s


Line 37: - dd 3Gb data volume on block domain: 67.16s +-2.19s [1]
Line 38: - qemu-img 2Gb data volume on block domain: 37.60s +-0.32s
Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s
>  Why qemu-img is faster - copying only allocated blocks? 
No, as
I stated below the volumes contained 2Gb of random data, and all the 2Gb are transferred
in both cases. It is  clearly specified where there was a different amount of transferred
data (note [1]).
Line 42: 
Line 43: All the volumes contained the same (u)random data.
Line 44: 
Line 45: [1] here dd pays the price of having to copy the entire chunk of


Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s
Line 42: 
Line 43: All the volumes contained the same (u)random data.
>  Is this typical? I think we should test typical volume - for example,
> syste 
The random data is the worst case. In the other cases qemu-img will always
perform better because it transfers only the allocated data and you can't do a fair
comparison.
Line 44: 
Line 45: [1] here dd pays the price of having to copy the entire chunk of
Line 46:     allocated space (3Gb vs 2Gb of real data). Anyway even when
Line 47:     normalized to the same amount of data it's still slower.


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/5//COMMIT_MSG
Commit Message:

Line 39: 
Line 40: - dd 2Gb data volume on file domain: 79.02s +-7.44s
Line 41: - qemu-img 2Gb data volume on file domain: 56.92s +-12.37s
Line 42: 
Line 43: All the volumes contained the same (u)random data.
>  The random data is the worst case. In the other cases qemu-img will
> always  
Can you add the missing info added in your replies to the commit message?
Line 44: 
Line 45: [1] here dd pays the price of having to copy the entire chunk of
Line 46:     allocated space (3Gb vs 2Gb of real data). Anyway even when
Line 47:     normalized to the same amount of data it's still slower.


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

automation(a)ovirt.org has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 6:

* Update tracker::#1156115::OK
* Check Bug-Url::OK
* Check Public Bug::#1156115::OK, public bug
* Check Product::#1156115::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 6: Verified+1

Verified with cold and live disk move. At the end of each move the chain was still correct
and the data was not squashed.

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15306/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15137/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14349/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 6: Code-Review+2

Raising

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


image: use qemu-img convert to copy internal volumes

According to the qemu-img manual:

 You can use the backing_file option to force the output image to be
 created as a copy on write image of the specified base image; the
 backing_file should have the same content as the input's base image,
 however the path, image format, etc may differ.

The benefits to use qemu-img convert instead of dd to copy the internal
volumes are:

- we unify operations under just one tool that is specific for image
  manipulations

- copying images from block domains we won't copy the entire chunk
  (1Gb) but only the amount of data really in use

- qemu-img when copying images tries to re-sparsify them, so on certain
  occasion the destination image will be shrinked to a smaller size

The downside is the additional call to getParentVolume (that seems
trascurable compared to the amount of data that we're going to copy).

The following statistics were gathered using:

 coreutils-8.4-37.el6.x86_64
 kernel-2.6.32-504.1.3.el6.x86_64
 qemu-img-rhev-0.12.1.2-2.415.el6_5.3.x86_64

each copy ran 5 times; the reported values are the average and the
standard deviation:

- dd 3Gb data volume on block domain: 67.16s +-2.19s [1]
- qemu-img 2Gb data volume on block domain: 37.60s +-0.32s

- dd 2Gb data volume on file domain: 79.02s +-7.44s
- qemu-img 2Gb data volume on file domain: 56.92s +-12.37s

All the volumes contained the same (u)random data which is the
worst case: qemu-img is forced to transfer each cluster of the image
as dd does (in all the other cases qemu-img transfers less data).
The only case where the amount of data transfered is different is
explicitly mentioned.

[1] here dd pays the price of having to copy the entire chunk of
    allocated space (3Gb vs 2Gb of real data). Anyway even when
    normalized to the same amount of data it's still slower.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1156115
Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/33355
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 20 insertions(+), 14 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

automation(a)ovirt.org has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 7:

* Update tracker::#1156115::OK
* Check TR::#1156115::ERROR, 3.6.0 should not match .*

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6344/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/524/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/522/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/517/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/499/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4509/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No