Nir Soffer has posted comments on this change.
Change subject: image: use qemu-img convert to copy internal volumes
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/33355/3//COMMIT_MSG
Commit Message:
Line 10:
Line 11: You can use the backing_file option to force the output image to be
Line 12: created as a copy on write image of the specified base image; the
Line 13: backing_file should have the same content as the input's base image,
Line 14: however the path, image format, etc may differ.
Does this create dependency between unrelated volumes?
Line 15:
Line 16: The benefits to use qemu-img convert instead of dd to copy the internal
Line 17: volumes are:
Line 18:
Line 19: - we unify operations under just one tool that is specific for image
Line 20: manipulations
Line 21:
Line 22: - copying images from block domains we won't copy the entire chunk
Line 23: (1Gb) but only the amount of data really in use
But if volumes are big, copying with dd is faster, at least to NFS:
https://bugzilla.redhat.com/show_bug.cgi?id=1132219
Line 24:
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
Line 27:
Line 23: (1Gb) but only the amount of data really in use
Line 24:
Line 25: The downside is the additional call to getParentVolume (that seems
Line 26: trascurable compared to the amount of data that we're going to copy).
Line 27:
Bug-Url? see
http://gerrit.ovirt.org/#/c/33355/2//COMMIT_MSG
Line 28: Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
http://gerrit.ovirt.org/#/c/33355/3/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 432: volUUID=srcVol.volUUID)
Line 433: srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434: dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435:
Line 436: pntVol = dstVol.getParentVolume()
maybe 'parentVolume' is more readable?
Or parentVol as
I suggested in the previous patch
Line 437:
Line 438: if pntVol is not None:
Line 439: backing = volume.getBackingVolumePath(
Line 440: imgUUID, pntVol.volUUID)
--
To view, visit
http://gerrit.ovirt.org/33355
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes