Change in vdsm[master]: void check pool masterver not zero when connecting

Royce Lv has uploaded a new change for review.

Change subject: void check pool masterver not zero when connecting
......................................................................

void check pool masterver not zero when connecting

when first connect a pool with masterVersion 0(not "0") ,pool.getPoolParams will
be called to read connection info from saved file which is created later when
pool.connect,trigger getPoolParam reports error

Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/2645/1
--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;

Adam Litke has posted comments on this change.

Change subject: void check pool masterver not zero when connecting
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Just a couple of suggested fixes for you to make and you can resubmit it.

....................................................
File vdsm/storage/hsm.py
Line 839
You could have the same issue here as well (and several other places in this function).

Line 847:             if not hostID or not scsiKey or not msdUUID:    
1. You have some trailing whitespace here.
2. I don't think you can just remove the check here.  The better way to fix this is to
stop relying on Python's boolean semantics for these checks:

if hostID is None or scsiKey is None or msdUUID is None:

This way you are actually checking for a missing parameter.

--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: void check pool masterver not zero when connecting
......................................................................


Patch Set 1: I would prefer that you didn't submit this

oh, and please keep the commit message with shorter lines (and shorter sentences; I cannot
say that I understand the problem that you are fixing)

--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Royce Lv has abandoned this change.

Change subject: void check pool masterver not zero when connecting
......................................................................


Patch Set 1: Abandoned

submit another change

--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;