Nir Soffer has uploaded a new change for review.
Change subject: tests: Fail if abort was not called ......................................................................
tests: Fail if abort was not called
The StuckJob was waiting one second and terminating silently even if the test never called abort. Now we raise RuntimeError in this case.
Change-Id: If71d2aeeb4a4242678253845071f68f3a9b12f5d Signed-off-by: Nir Soffer nsoffer@redhat.com --- M tests/jobsTests.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65207/1
diff --git a/tests/jobsTests.py b/tests/jobsTests.py index 3b39277..520c98d 100644 --- a/tests/jobsTests.py +++ b/tests/jobsTests.py @@ -85,7 +85,8 @@
def _run(self): self.event_running.set() - self.event_aborted.wait(1) + if not self.event_aborted.wait(1): + raise RuntimeError("Timeout waiting for abort")
def _abort(self): self.event_aborted.set()
gerrit-hooks has posted comments on this change.
Change subject: tests: Fail if abort was not called ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: tests: Fail if abort was not called ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
vdsm-patches@lists.fedorahosted.org