Federico Simoncelli has posted comments on this change.
Change subject: BZ#740887 Tune cache dirty ratio
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/misc.py
Line 1147:
Line 1148: def getfds():
Line 1149: return [int(fd) for fd in os.listdir("/proc/self/fd")]
Line 1150:
Line 1151: def setDirtyRatio(ratio=20):
Because the kernel defaults are different than what we set. If we consider this to be a
misc utility library (that in theory anyone could use) I'd rather keep the kernel
values as defaults and let vdsm set what it needs.
Line 1152: with file("/proc/sys/vm/dirty_ratio", "w") as f:
Line 1153: f.write(ratio)
Line 1154:
Line 1155: def setDirtyBackgroundRatio(ratio=10):
--
To view, visit
http://gerrit.usersys.redhat.com/970
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>