Change in vdsm[master]: vdsm: Attaching a console should be controllable

[Vinzenz Feenstra]

Vinzenz Feenstra has uploaded a new change for review.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

vdsm: Attaching a console should be controllable

Added a new VmParameter 'attachConsole' which defines
whether or not a console should be attached upon creation

Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Signed-off-by: Vinzenz Feenstra 
---
M vdsm/libvirtvm.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 7 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/9359/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index ca31a43..16e081f 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1260,7 +1260,9 @@
                         _QEMU_GA_DEVICE_NAME)
         domxml.appendInput()
         domxml.appendGraphics()
-        domxml.appendConsole()
+
+        if utils.tobool(self.conf.get('attachConsole', 'false')):
+            domxml.appendConsole()

for devType in self._devices:
             for dev in self._devices[devType]:
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 6591410..f736307 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2379,6 +2379,9 @@
 #
 # @vmType:                The type of VM
 #
+# @attachConsole:         Defines if a virtio-console should be attached to the
+#                         virtual machine
+#
 # Since: 4.10.0
 ##
 {'type': 'VmParameters',
@@ -2388,7 +2391,7 @@
           'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint',
           'smpThreadsPerCore': 'uint', 'timeOffset': 'uint',
           'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
-          'vmType': 'VmType'}}
+          'vmType': 'VmType', 'attachConsole': 'bool'}}

##
 # @VmInfo:

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/66/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/99/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/66/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/99/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/100/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/67/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/67/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/100/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/69/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/102/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/69/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/102/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

should this be a parameter, or a device? how does it relate to stable device addresses handling

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

Well the only change done here is to make it optional.
There is no other change.

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

true, but now that it becomes an engine managed device, question is if it shouldn't be managed as a device

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

how about controlling the communication to the console (serial/virtio)? Ancient guest operating system - that does not have virtio - may need/want this.

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

Michal Skrivanek has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

"true, but now that it becomes an engine managed device, question is if it shouldn't be managed as a device"
there can be only one. It doesn't make sense to have multiple, Linux supports only 1, Windows doesn't support it at all.

"how about controlling the communication to the console (serial/virtio)? Ancient guest operating system - that does not have virtio - may need/want this."
true. however:
- in ovirt we support only recent enough anyway
- iirc there are some issues with virtio-serial implementation and qemu/kvm is planning to get rid of the code longterm. at least that's what i've heard:-)

so - is it worth it? do we want to expose it in the engine? or maybe just allow it in vdsm?

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 3:

Well, when I've added console, I thought it's good for VMs of all creeds. But I was proven wrong - I suspect that if WinXP would not crash and burn with regular serial console (not virtio-serial, but the old rs-232 card).

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/170/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/204/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/170/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/204/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/206/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/172/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5: I would prefer that you didn't submit this

Messed up api definition

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5: No score

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/172/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/206/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Vinzenz Feenstra]

Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5:

The messed up API definition was on Patchset 4

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

Patch Set 5: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2350: # Properties of a VM console device.
Line 2351: #
Line 2352: # @deviceType:  The device type (always @console)
Line 2353: #
Line 2354: # @deviceId:    A unique ID for this device
Ok... I can leave the api with virtio console as a default.

If we ever need to add serial console we could add consoleType parameter.
Line 2355: #
Line 2356: # Since: 4.10.0
Line 2357: ##
Line 2358: {'type': 'VmConsoleDevice',

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: Attaching a console should be controllable
......................................................................

vdsm: Attaching a console should be controllable

Added a new console device which enables the engine to
define that the virtual machine shall have a virtio console

VDSM will upon creation insert a console with pty type and
a 'virtio' target device on port 0

Updated libvirtvm test to correspond with the changes

Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Signed-off-by: Vinzenz Feenstra 
---
M tests/libvirtvmTests.py
M vdsm/libvirtvm.py
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
4 files changed, 45 insertions(+), 26 deletions(-)

Approvals:
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Frank Kobzik 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: oVirt Jenkins CI Server