12:51 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
deployUtil: isOvirt() check oVirt release
Adding support to isOvirt() to validate oVirt Node
Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
---
M vdsm_reg/deployUtil.py.in
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/452/1
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
12:55 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 1:
Going to provide a new version without the space character in the end. git diff --check
will help me next time.
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
1:13 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
3:33 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:36 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 3:
Are these patches enough? I am missing the fixes for /etc/init.d/vdsmd
[ -f /etc/rhev-hypervisor-release ]
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:47 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 3:
There is another patch which will change vdsmd.init.in.
http://gerrit.ovirt.org/455
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:29 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:53 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
deployUtil: isOvirt() check oVirt release
Adding support to isOvirt() to validate oVirt Node
Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
---
M vdsm_reg/deployUtil.py.in
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:53 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: isOvirt() check oVirt release
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada58298552a316f71ed2b99b1fbced48ceee67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4536
days inactive
4545
days old
vdsm-patches@lists.fedorahosted.org
8 comments
2 participants
participants (2)
-
Dan Kenigsberg -
Douglas Schilling Landgraf