Change in vdsm[master]: Move gluster/{cli.py, exception.py} to vdsm rpm

Deepak C Shetty has uploaded a new change for review.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................

Move gluster/{cli.py, exception.py} to vdsm rpm

This move is being done so that vdsm code using gluster cli
doesn't have the need to depend on vdsm-gluster rpm

Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Signed-off-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/8033/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 5b1fa92..797a2ed 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -692,6 +692,8 @@
 %{_datadir}/%{vdsm_name}/neterrors.py*
 %{_datadir}/%{vdsm_name}/respawn
 %{_datadir}/%{vdsm_name}/set-conf-item
+%{_datadir}/%{vdsm_name}/gluster/cli.py*
+%{_datadir}/%{vdsm_name}/gluster/exception.py*
 %{python_sitelib}/sos/plugins/vdsm.py*
 /lib/udev/rules.d/12-vdsm-lvm.rules
 /etc/security/limits.d/99-vdsm.conf
@@ -929,8 +931,6 @@
 %doc COPYING
 %{_datadir}/%{vdsm_name}/gluster/__init__.py*
 %{_datadir}/%{vdsm_name}/gluster/api.py*
-%{_datadir}/%{vdsm_name}/gluster/cli.py*
-%{_datadir}/%{vdsm_name}/gluster/exception.py*
 %{_datadir}/%{vdsm_name}/gluster/hostname.py*
 
 %changelog


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7:

@shaohef,
    No. vdsm-gluster rpm provides ability in VDSM to manage gluster clusters, while my
patch here is to provide ability in VDSM to consume gluster cluster as a storage domain.
vdsm-gluster rpm has Requires of glusterfs-server which may not necessarily be needed for
consumign gluster, since its possible for gluster cluster to reside on some other host and
still be able to consume it from a diff host.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

ShaoHe Feng has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

a question:
will the vdsm-gluster rpm be  abandoned in the future?

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 6: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/401/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/436/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 6: Verified

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/436/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/401/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 5: Verified

Submitted as part of a new topic

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Shu Ming has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1: No score

(1 inline comment)

....................................................
File vdsm.spec.in
Line 692: %{_datadir}/%{vdsm_name}/neterrors.py*
Line 693: %{_datadir}/%{vdsm_name}/respawn
Line 694: %{_datadir}/%{vdsm_name}/set-conf-item
Line 695: %{_datadir}/%{vdsm_name}/gluster/cli.py*
Line 696: %{_datadir}/%{vdsm_name}/gluster/exception.py*
Done, will post v2.
Thanks fsimonce and Shu Ming for the review.
Line 697: %{python_sitelib}/sos/plugins/vdsm.py*
Line 698: /lib/udev/rules.d/12-vdsm-lvm.rules
Line 699: /etc/security/limits.d/99-vdsm.conf
Line 700: %{_mandir}/man8/vdsmd.8*


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 692: %{_datadir}/%{vdsm_name}/neterrors.py*
Line 693: %{_datadir}/%{vdsm_name}/respawn
Line 694: %{_datadir}/%{vdsm_name}/set-conf-item
Line 695: %{_datadir}/%{vdsm_name}/gluster/cli.py*
Line 696: %{_datadir}/%{vdsm_name}/gluster/exception.py*
It's not required for the creation but it's needed to explicitly say that such
directory is part of this rpm. We need it here.
Line 697: %{python_sitelib}/sos/plugins/vdsm.py*
Line 698: /lib/udev/rules.d/12-vdsm-lvm.rules
Line 699: /etc/security/limits.d/99-vdsm.conf
Line 700: %{_mandir}/man8/vdsmd.8*


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm.spec.in
Line 692: %{_datadir}/%{vdsm_name}/neterrors.py*
Line 693: %{_datadir}/%{vdsm_name}/respawn
Line 694: %{_datadir}/%{vdsm_name}/set-conf-item
Line 695: %{_datadir}/%{vdsm_name}/gluster/cli.py*
Line 696: %{_datadir}/%{vdsm_name}/gluster/exception.py*
I tested by doing rm -fr /usr/share/vdsm
and it works fine. 
Post install, /usr/share/vdsm/gluster dir was created.
Line 697: %{python_sitelib}/sos/plugins/vdsm.py*
Line 698: /lib/udev/rules.d/12-vdsm-lvm.rules
Line 699: /etc/security/limits.d/99-vdsm.conf
Line 700: %{_mandir}/man8/vdsmd.8*


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Shu Ming has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm.spec.in
Line 692: %{_datadir}/%{vdsm_name}/neterrors.py*
Line 693: %{_datadir}/%{vdsm_name}/respawn
Line 694: %{_datadir}/%{vdsm_name}/set-conf-item
Line 695: %{_datadir}/%{vdsm_name}/gluster/cli.py*
Line 696: %{_datadir}/%{vdsm_name}/gluster/exception.py*
Have you tested the installation of vdsm package without %{_datadir}/%{vdsm_name}/gluster
directory initially? I am suspicious a "%dir ${_datadir}/%{vdsm_name}/gluster"
directive is needed to create the directory?
Line 697: %{python_sitelib}/sos/plugins/vdsm.py*
Line 698: /lib/udev/rules.d/12-vdsm-lvm.rules
Line 699: /etc/security/limits.d/99-vdsm.conf
Line 700: %{_mandir}/man8/vdsmd.8*


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 1:

Verified by installing VDSM rpm and ensuring the cli and exception.py files are installed
as part of vdsm-xxx.rpm, without vdsm-gluster-xx.rpm present.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Bala.FA has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

ShaoHe Feng has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 3:

yes, you are right.

 since you have move the files from vdsm-gluster rpm to vdsm rpm, so there is no need to
check the modules of vdsm-gluster are available.

 actually they must be available, if not, test should report error.

 so you should remove the setUp function and the exception when you import the gluster
modules.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 3: No score

@shaohef,
    Thanks for your review. 
I have not understood the tests/ framework entirely, so want to put down my understanding
below...

1) vdsm-tests rpm has requires of vdsm rpm, so if vdsm-tests is installed, its safe to
assume vdsm rpm is also installed.

2)tests/main.py and tests/gluster_cli_tests.py are part of vdsm-tests rpm.

3) Since my patch moves gluster/cli,exception,hostname}.py to vdsm rpm, i feel there is no
need to check for Import error in tests/main.py and tests/gluster_cli_tests.py. It
effectively means I just make them as ...

main.py: from gluster import exception as gluster_exception
gluster_cli_tests.py: from gluster import cli as gcli

4) I will remove def setUp from main.py and gluster_cli_tests.py, since there is no need
of the checks it does, as gluster cli and exception are available as part of vdsm rpm.

Let me know and/or correct my above understanding, post which I can send the next
patchset.

thanx,
deepak

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

ShaoHe Feng has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 3: I would prefer that you didn't submit this

please also fix../tests/gluster_cli_tests.py and ../tests/main.py.
 these files in /test also import gluster.if gluster rpm is not installed, these test will
pass when can not import import gluster.

 now you have move gluster to vdsm rpm, the test should report  error when can not import
gluster.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Bala.FA has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 3: Verified

Verified by creating GLUSTERFS_DOMAIN storage domain, without having vdsm-gluster rpm
installed. Also addressed comments from Bala since patchset 2.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 2: No score

@Bala,
    The files are moved to vdsm ( not vdsm-python) rpm.
Is there any specific reason to move ot vdsm-python ? I thought vdsm rpm is the best fit.

I can remove the _glusterEnabled check in supervdsm.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Bala.FA has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 2:

If gluster/{cli,exception}.py are part of vdsm-python, I think, check of gluster cli
import in superVdsmServer.py is not required.

I am not sure whether this patch covers this.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
......................................................................


Patch Set 2: I would prefer that you didn't submit this

I'm marking this with -1 not because it is wrong, only because I would not like to
merge this before seeing how it is required by other patches in this topic branch.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/567/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/602/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/602/ (2/2)

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/567/ (1/2)

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

Deepak C Shetty has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7: Verified

fixed issues reported by jenkins

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm

This move is being done so that vdsm code using gluster cli
doesn't have the need to depend on vdsm-gluster rpm

Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Signed-off-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
---
M tests/gluster_cli_tests.py
M tests/main.py
M vdsm.spec.in
M vdsm/supervdsmServer.py
4 files changed, 18 insertions(+), 47 deletions(-)

Approvals:
  ShaoHe Feng: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Deepak C Shetty: Verified


--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Move gluster/{cli, exception, hostname, __init__}.py to vdsm rp...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................


Patch Set 7: Looks good to me, approved

I'm not crazy about the added files, but I suppose vdsm gains much out of this.

--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server