8:14 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
Adding python-pthreading as BuildRequires for rhel >= 7
Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=891542
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/10840/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index c9b51c0..18ef664 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -51,6 +51,10 @@
BuildRequires: python-ordereddict
%endif
+%if 0%{?rhel} >= 7
+BuildRequires: python-pthreading
+%endif
+
# Autotools BuildRequires
%if 0%{?enable_autotools}
BuildRequires: autoconf
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
11:24 p.m.
Mark Wu has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1:
Douglas,
I am confused by why python-pthreading is unconditionally required for installation, but
for build it's only required on fedora. How to meet the installation requirement of
python-pthreading on rhel6, fetching package from EPEL repo? If yes, why not just
unconditionally requires python-pthreading for build?
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:27 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2: Looks good to me, approved
Thanks.
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:27 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
Mark Wu has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:27 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
vdsm.spec: BuildRequires: python-pthreading
Moving python-pthreading to be a generic BuildRequirement
Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=891542
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Mark Wu: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:05 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/627/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:08 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/627/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/662/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:05 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:05 a.m.
New subject: Change in vdsm[master]: vdsm.spec: BuildRequires: python-pthreading
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/662/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:51 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1:
Mark, I got the point and agreed, thanks!
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:15 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/618/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/653/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:14 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/618/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:14 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:14 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BuildRequires: python-pthreading for rhel >= 7
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/653/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If996c366cac42e149193651d2d8a6dbde6d8c81e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4162
days inactive
4162
days old
vdsm-patches@lists.fedorahosted.org
13 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Jenkins CI RO -
wudxw＠linux.vnet.ibm.com