Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register-to-engine: remove duplicate code ......................................................................
register-to-engine: remove duplicate code
commit 9ee977d9e7edc688ae81db752041a05085f30cb2 moved isHostReachable() to vdsm/netinfo.py for others parts of code use it. This patch will remove isHostReachable() from register-to-engine and update all calls to netinfo.isHostReachable()
Change-Id: Ifd898dcde7077508ce1a8e63f39836c6b7956684 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm_reg/register-to-engine.py 1 file changed, 3 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/6253/1 -- To view, visit http://gerrit.ovirt.org/6253 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd898dcde7077508ce1a8e63f39836c6b7956684 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Bala.FA has posted comments on this change.
Change subject: register-to-engine: remove duplicate code ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6253 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd898dcde7077508ce1a8e63f39836c6b7956684 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register-to-engine: remove duplicate code ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I will submit a new code.
-- To view, visit http://gerrit.ovirt.org/6253 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifd898dcde7077508ce1a8e63f39836c6b7956684 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has abandoned this change.
Change subject: register-to-engine: remove duplicate code ......................................................................
Patch Set 1: Abandoned
Not required anymore.
-- To view, visit http://gerrit.ovirt.org/6253 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ifd898dcde7077508ce1a8e63f39836c6b7956684 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
vdsm-patches@lists.fedorahosted.org