Yaniv Kaul has posted comments on this change.
Change subject: Adding memTotal metric
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/62154/4/lib/vdsm/host/api.py
File lib/vdsm/host/api.py:
Line 93: data[storage_prefix + '.last_check'] =
dom_info['lastCheck']
Line 94:
Line 95: data[prefix + '.memory.available'] =
hoststats['memAvailable']
Line 96: data[prefix + '.memory.committed'] =
hoststats['memCommitted']
Line 97: data[prefix + '.memory.free_mb'] = hoststats['memFree']
what is the _mb suffix here?
Line 98: data[prefix + '.memory.usage_percent'] =
hoststats['memUsed']
Line 99: data[prefix + '.memory.total_M'] = hoststats['memTotal']
Line 100: data[prefix + '.memory.anon_huge_pages'] =
hoststats['anonHugePages']
Line 101:
https://gerrit.ovirt.org/#/c/62154/4/lib/vdsm/host/stats.py
File lib/vdsm/host/stats.py:
Line 77: stats['cpuSys'] = jiffies / interval / last_sample.ncpus
Line 78: stats['cpuIdle'] = max(0.0,
Line 79: 100.0 - stats['cpuUser'] -
stats['cpuSys'])
Line 80: stats['memUsed'] = last_sample.memUsed
Line 81: stats['memTotal'] = last_sample.MemTotal / 1024
is this now in bytes? why do we perform the division here, but not in memUsed above?
Line 82: stats['anonHugePages'] = last_sample.anonHugePages
Line 83: stats['cpuLoad'] = last_sample.cpuLoad
Line 84:
Line 85: stats['diskStats'] = last_sample.diskStats
--
To view, visit
https://gerrit.ovirt.org/62154
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b237aa559f8b0ca835fb55c1205b2766c656a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes