Yaniv Kaul has posted comments on this change.
Change subject: Adding units to memory metrics name according to metrics2.0 spec
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/metrics/__init__.py
File lib/vdsm/metrics/__init__.py:
Line 23: import importlib
Line 24: from ..config import config
Line 25:
Line 26: # METRIC UNIT SUFFIX REPRESENTATION
Line 27: MB = '_M'
I was not convinced it is _M and not _Mi - please check.
Line 28:
Line 29: _reporter = None
Line 30:
Line 31:
--
To view, visit
https://gerrit.ovirt.org/62155
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes