Change in vdsm[master]: nfs-check: check if /tmp exists

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: nfs-check: check if /tmp exists
......................................................................

nfs-check: check if /tmp exists

I have received a debian user reporting that nfs-check didn't work..
analysing the case, we discovered that the system didn't contain /tmp
directory.

Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
---
M contrib/nfs-check.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/3167/1
--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: nfs-check: check if temp dir exists

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has abandoned this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: Abandoned

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: nfs-check: check if temp dir exists

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/69/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: nfs-check: check if temp dir exists

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/69/

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: nfs-check: check if temp dir exists

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File contrib/nfs-check.py
Line 254:     LOCALPATH = tempfile.mkdtemp()
gerrit needs a needinfo flag urgently. please use private email or list humiliation if I
ignore direct questions for so long.

I do not understand your question. why do you mind using $PWD as your tempdir as a last
resort?

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: nfs-check: check if temp dir exists

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: (3 inline comments)

....................................................
File contrib/nfs-check.py
Line 29: TMPDIR	    = "/tmp"
heehe indeed.

Line 249:     tempfile.tempdir = TMPDIR
Please see below.

Line 254:     LOCALPATH = tempfile.mkdtemp()
Currently, nfs-check already share the cause of the problem with error like
"Permission denied". What about if we don't find  /tmp or /var/tmp
(following FHS) we set the 1777 (as tmp dir) permissions to the random path? 

Here an example of directory creation when there is no /tmp and/or /var/tmp:

# ls -la .
drwx------  2 root      root      4096 Mar 29 22:39 tmpUvzCBb

Note: When users doesn't have /tmp or /var/tmp the next path will be current path.

Here an example of executing without /tmp and /var/tmp:
# sudo python nfs-check.py 192.168.1.218:/storage
Executing NFS tests..
/home/dougsland/tmpDIR/vdsm/contrib/tmp4SxUXi
Permission denied: vdsm user as kvm cannot create a file into
/home/dougsland/tmpDIR/vdsm/contrib/tmp4SxUXi
Suggestions: please verify the permissions of target (chmod or/and selinux booleans)
return = 1 error msg = /bin/touch: cannot touch
`/home/dougsland/tmpDIR/vdsm/contrib/tmp4SxUXi/vdsmTest': Permission denied
Status of tests [Failed]
Disconnecting from NFS Server..
Done!

Please let me know your opinion.
Thanks!

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: nfs-check: check if temp dir exists

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: nfs-check: check if /tmp exists
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: nfs-check: check if temp dir exists

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: nfs-check: check if temp dir exists
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File contrib/nfs-check.py
Line 29: TMPDIR	    = "/tmp"
evil tab

Line 249:     tempfile.tempdir = TMPDIR
why do you force the user to use /tmp? maybe his $TEMPDIR is /var/tmp, why should you
care?

Line 254:     LOCALPATH = tempfile.mkdtemp()
I suppose it would be safe to solve the issue by reporting a clear exception here (if
indeed this operation failed)

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;