5:53 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Makefile: replace astrisks with equal signs
Tripple astrisks are used to mark failures in make and other utilities.
Let us use '===' instead for comments.
Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/79750/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 464850f..734e80d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -304,16 +304,16 @@
@true
check-net:
- @echo '*** Running networking tests. ***'
+ @echo '=== Running networking tests. ==='
@$(top_srcdir)/tests/run_tests_local.sh $(network_modules)
check-virt:
- @echo '*** Running virt tests. ***'
+ @echo '=== Running virt tests. ==='
@$(top_srcdir)/tests/run_tests_local.sh $(virt_modules)
check:
- @echo '*** Running tests. To skip this step place NOSE_EXCLUDE=.* ***'
- @echo '*** into your environment. Do not submit untested code! ***'
+ @echo '=== Running tests. To skip this step place NOSE_EXCLUDE=.* ==='
+ @echo '=== into your environment. Do not submit untested code! ==='
$(top_srcdir)/tests/run_tests_local.sh $(run_modules)
if [ "$(PYTHON3_SUPPORT)" == "1" ]; then \
all_modules=`mktemp`; \
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7:01 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Patch Set 3:
ci please build
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:31 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Patch Set 3:
http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tes...
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
9:38 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Patch Set 3: Verified+1
passes CI
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:30 p.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. (
https://gerrit.ovirt.org/79750 )
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Makefile: replace astrisks with equal signs
Tripple astrisks are used to mark failures in make and other utilities.
Let us use '===' instead for comments.
Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
2469
days inactive
2469
days old
vdsm-patches@lists.fedorahosted.org
4 comments
1 participants
participants (1)
-
Code Review