1:41 p.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................
move constants.SUPPORTED_BLOCKSIZE to its sole user
Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
M lib/vdsm/storage/lvm.py
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/79731/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 2d16d31..68c8b7a 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -55,7 +55,6 @@
# This is the domain version translation list
# DO NOT CHANGE OLD VALUES ONLY APPEND
DOMAIN_VERSIONS = (0, 2, 3, 4)
-SUPPORTED_BLOCKSIZE = (512,)
# This contains the domains versions that this VDSM
# accepts currently its all of the version but in the
diff --git a/lib/vdsm/storage/lvm.py b/lib/vdsm/storage/lvm.py
index 3421d20..7d26d9c 100644
--- a/lib/vdsm/storage/lvm.py
+++ b/lib/vdsm/storage/lvm.py
@@ -71,6 +71,8 @@
LV_ATTR = namedtuple("LV_ATTR", LV_ATTR_BITS)
Stub = namedtuple("Stub", "name, stale")
+SUPPORTED_BLOCKSIZE = (512,)
+
class Unreadable(Stub):
__slots__ = ()
@@ -1095,7 +1097,7 @@
pvBlkSize = _getpvblksize(pv)
logPvBlkSize, phyPvBlkSize = pvBlkSize
- if logPvBlkSize not in constants.SUPPORTED_BLOCKSIZE:
+ if logPvBlkSize not in SUPPORTED_BLOCKSIZE:
raise se.DeviceBlockSizeError(pvBlkSize)
if phyPvBlkSize < logPvBlkSize:
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
1:03 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/79731/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-07-23 21:18:43 +0300
Line 4: Commit: Dan Kenigsberg <danken(a)redhat.com>
Line 5: CommitDate: 2017-07-23 21:18:43 +0300
Line 6:
Line 7: move constants.SUPPORTED_BLOCKSIZE to its sole user
This is a fundamental storage constant that may need to be used by
other co
I prefer to keep things local until they have an actual external consumer.
but it's your code, so we'd place this whereever your want.
Line 8:
Line 9: Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
2:23 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................
Patch Set 1: Verified+1
OST passes
http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tes...
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
9:37 a.m.
New subject: Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants
......................................................................
Patch Set 3: Verified+1
OST is happy http://jenkins.ovirt.org/view/oVirt system
tests/job/ovirt-system-tests_manual/855
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:41 p.m.
New subject: Change in vdsm[master]: move constants.SUPPORTED_BLOCKSIZE to storage.constants
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. (
https://gerrit.ovirt.org/79731 )
Change subject: move constants.SUPPORTED_BLOCKSIZE to storage.constants
......................................................................
move constants.SUPPORTED_BLOCKSIZE to storage.constants
Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
M lib/vdsm/storage/constants.py
M lib/vdsm/storage/lvm.py
3 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
2482
days inactive
2483
days old
vdsm-patches@lists.fedorahosted.org
4 comments
1 participants
participants (1)
-
Code Review