From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/79731/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-07-23 21:18:43 +0300
Line 4: Commit: Dan Kenigsberg <danken(a)redhat.com>
Line 5: CommitDate: 2017-07-23 21:18:43 +0300
Line 6:
Line 7: move constants.SUPPORTED_BLOCKSIZE to its sole user
This is a fundamental storage constant that may need to be used by
other co
I prefer to keep things local until they have an actual external consumer.
but it's your code, so we'd place this whereever your want.
Line 8:
Line 9: Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
--
To view, visit
https://gerrit.ovirt.org/79731
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes