Change in vdsm[master]: Improves logging when attempting to run hooks for a vm.

Lee Yarwood has uploaded a new change for review.

Change subject: Improves logging when attempting to run hooks for a vm.
......................................................................

Improves logging when attempting to run hooks for a vm.

Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
---
M vdsm/hooks.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/243/1
--
To view, visit http://gerrit.ovirt.org/243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Improves logging when attempting to run hooks for a vm.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/hooks.py
Line 62:             logging.info('attempting to run hook %s for vm %s',s,vmid)
Please keep a space after comma.

--
To view, visit http://gerrit.ovirt.org/243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Improves logging when attempting to run hooks for a vm.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/hooks.py
Line 62:             logging.info('attempting to run hook %s for vm %s', s, vmid)
Lee, for some reason, my serious comment to your former patch was not sent.

I've asked why do you think this change is helpful: isn't execCmd's log, which
explicitly lists the module name (hooks), enough?

--
To view, visit http://gerrit.ovirt.org/243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;

Lee Yarwood has abandoned this change.

Change subject: Improves logging when attempting to run hooks for a vm.
......................................................................


Patch Set 2: Abandoned

As agreed with Dan hooks are already logged by execCmd and thus is not required.

--
To view, visit http://gerrit.ovirt.org/243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;