Change in vdsm[master]: bz773364 cancel-migration: abort migration on dest results a...

Shahar Havivi has uploaded a new change for review.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................

bz773364 cancel-migration: abort migration on dest results an exception

while starting migration, it appear in dest host vm list.
when trying to cancel migration the _dom have not set, and when trying
to call abortJob() we get AttributeError() exception.

Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/1041/1
--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;

Change in vdsm[master]: BZ#773364 cancel-migration: abort migration on dest results ...

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#773364 cancel-migration: abort migration on dest results an exception
......................................................................


BZ#773364 cancel-migration: abort migration on dest results an exception

While starting migration, it appear in dest host vm list.
When trying to cancel migration the _dom have not set, and when trying
to call abortJob() we get AttributeError() exception.

Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
---
M vdsm/vm.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Change in vdsm[master]: BZ#773364 cancel-migration: abort migration on dest results ...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 1024:         except AttributeError:
come to think of this, AttributeError is a bit too general, and this patch may hide and
complicate future bugs. I'd say, check here is _dom is None, and if not - raise.

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;