Change in vdsm[master]: bz773364 cancel-migration: abort migration on dest results a...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 1024:         except AttributeError:
come to think of this, AttributeError is a bit too general, and this patch may hide and
complicate future bugs. I'd say, check here is _dom is None, and if not - raise.

--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;