6:49 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Move the vdsm package to sitearch
......................................................................
Move the vdsm package to sitearch
In this patch:
* move the vdsm package to the sitearch directory
* improve the build process for the betterPopen module
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
---
M configure.ac
M vdsm.spec.in
M vdsm/betterPopen/Makefile.am
3 files changed, 29 insertions(+), 32 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/5164/1
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
1:11 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move the vdsm package to sitearch
......................................................................
Move the vdsm package to sitearch
In this patch:
* move the vdsm package to the sitearch directory
* improve the build process for the betterPopen module
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
---
M configure.ac
M vdsm.spec.in
M vdsm/betterPopen/Makefile.am
3 files changed, 29 insertions(+), 32 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:11 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:52 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1: Verified
moved to the correct code review + verified.
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:45 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1: I would prefer that you didn't submit this
As we talked over irc, distcheck is complaining about it.
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:50 a.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:49 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1:
As we talked over irc, distcheck is complaining about it.
Actually on the irc we said the opposite :)
The patch is going to fix the distcheck issue of betterPopen.
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:41 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Move the vdsm package to sitearch
......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
How about putting betterPopen in its own rpm, and outside of the vdsm sitepackage? It is
something that may be useful to non-vdsm users. But that's probably for another
patch.
--
To view, visit http://gerrit.ovirt.org/5164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a51ac77d5cf263ae7e96ac0c1f67eab75834d63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4374
days inactive
4378
days old
vdsm-patches@lists.fedorahosted.org
7 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
Federico Simoncelli