Dan Kenigsberg has posted comments on this change.
Change subject: BZ#737104 Disallow cross-vendor virtualization.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Thank! I have a couple of requests, though.
....................................................
Commit Message
Line 8:
please add:
"find vendor for all cpu models, including those based on another cpu module"
....................................................
File vdsm/caps.py
Line 109: cpu_map = minidom.parseString(
would you mind moving the code from here to line128 out to its own
_getAllCpuModels()
function? That would be more easily testable. I'd like to have a unittest, verifying
that Westmere is an Intel, etc.
Line 120: # If current model doesn't have a vendor, check if it have a
model
if it have -> if it has
Line 146: in allModels.items() if compatible(model, vendor) ]
no need to copy allModels's content - allModels.iteritems() is better.
--
To view, visit
http://gerrit.ovirt.org/5035
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52f757971e28058257d819036e58e0f1925c44d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>