[NEW PATCH] BZ#727509 Vdsm-reg should get RHEVM certificates (via gerrit-bot)

[Federico Simoncelli]

New patch submitted by Federico Simoncelli ([e-mail])

You can review this change at: http://gerrit.usersys.redhat.com/779

commit 35adf49436ce00b4c8638fb87e20aa05e364a022
Author: Federico Simoncelli 
Date:   Tue Aug 2 15:46:12 2011 +0000

BZ#727509 Vdsm-reg should get RHEVM certificates

Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73

diff --git a/vdsm_reg/vdsm-reg-setup.py b/vdsm_reg/vdsm-reg-setup.py
index b1015b8..ed88f32 100755
--- a/vdsm_reg/vdsm-reg-setup.py
+++ b/vdsm_reg/vdsm-reg-setup.py
@@ -192,6 +192,10 @@ class Setup:
             logging.debug("execute: after renameBridge: " + str(fOK))

if fOK:
+            fOK = deployUtil.getRhevmCert(self.vdcURL, self.vdcPORT)
+            logging.debug("execute: after getRhevmCert: " + str(fOK))
+
+        if fOK:
             strKey = deployUtil.getAuthKeysFile(self.vdcURL, self.vdcPORT)
             if strKey is not None:
                 fOKNow = deployUtil.handleSSHKey(strKey)

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_reg/vdsm-reg-setup.py
Line 196:             logging.debug("execute: after getRhevmCert: " + str(fOK))
huh? how did it ever work without it?

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm_reg/vdsm-reg-setup.py
Line 196:             logging.debug("execute: after getRhevmCert: " + str(fOK))
I asked that very same question in a bug comment :-)

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

Alan Pevec has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_reg/vdsm-reg-setup.py
Line 197: 
In rhevm.py cert was supposed to be downloaded when cert verification was selected, so it should've worked at least in that flow. But since Pavel filed 727509 while verifying 602338, it seems it wasn't working even with cert verification selected. I'd ask Pavel to quickly verify this patch on his setup.

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 1: I would prefer that you didn't submit this

I think I got it. vdsm-conf download the certificates - but only when fingeprint is verified. it should download the cert even if [[ -z $fingerprint ]].

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Yotam Oron]

Yotam Oron has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 2: (2 inline comments)

....................................................
File vdsm_reg/deployUtil.py
Line 1366:         if not options.serverIp or not options.serverPort:
It is not mandatory since the certificate is downloaded weather we have or haven't got the fingerprint (if it is there it is verified)

....................................................
File vdsm_reg/rhevm.py
Line 158:                 ButtonChoiceWindow(self.ncs.screen, "RHEV-M Configuration", 
No, haven't checked it due to time and resources ...

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

Alan Pevec has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 1: No score

Both, vdsm-config for autoinstall case and rhevm.py for interactive setup, must unconditionally download rhevm cert.

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Yotam Oron]

Yotam Oron has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

Alan Pevec has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_reg/vdsm-config
Line 90:                     res=`python "$DEPLOY_UTIL" --invalidate-rhevm-cert`
nitpicking: use tabs here like the rest of this file (not that I like tabs, but file formatting should be consistent)

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

wouldn't the correct approach be NOT to try to download the certificate ahead of time if it is not required for fingerprint validation?

....................................................
File vdsm_reg/deployUtil.py
Line 1361:             help="Invalidaterhevm certificate so that consequent RHEVM registrations will fail")
Invalidate RHEV-M

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron

Change in vdsm[master]: BZ#727509 Vdsm-reg should get RHEVM certificates

[Federico Simoncelli]

Federico Simoncelli has abandoned this change.

Change subject: BZ#727509 Vdsm-reg should get RHEVM certificates
......................................................................

Patch Set 3: Abandoned

Looks like nobody cares about this anymore.

--
To view, visit http://gerrit.usersys.redhat.com/779
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I09673ab7bc9fa5dc99829eb6b8d6a65bc13d0e73
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Alan Pevec 
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Yotam Oron