10:28 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Hack to fix vdsm-tool import issues during upgrade
In oVirt 3.5 (vdsm 4.16) we started to install vdsm site-packages under /usr/lib
(python_sitelib). In sys.path the import order first check under
/usr/lib64. While upgrading vdsm 3.4 to 3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1200467
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/39410/1
diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 8fa3bc5..e46bb21 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -28,8 +28,30 @@
import syslog
import traceback
+########################################################################
+# Ugly hack for 3.5 which switches the use of /usr/lib64 to /usr/lib.
+#
+# To avoid loading vdsm-tool verbs from old location (/usr/lib64)
+# we need to explicit import vdsm.tool from /usr/lib.
+# On upgrade from 3.4-3.5 when this directory change first introduced
+# we load vdsm.tool from /usr/lib64 before 3.4 package got removed.
+#
+# This leads to upgrade errors on vdsm-tool calls. With this ugly fix
+# I first add to path /usr/lib, import and then remove sys.path changes.
+# If I don't remove the changes it leads to other issues when
+# importing seobject.
+########################################################################
+
+sys.path.insert(0, '/usr/lib/python2.6/site-packages')
+sys.path.insert(0, '/usr/lib/python2.7/site-packages')
+
import vdsm.tool
+sys.path.pop(0)
+sys.path.pop(0)
+
+########################################################################
+
tool_modules = []
tool_command = {}
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
10:28 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:28 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17410/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:28 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:33 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17584/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:35 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17410/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17584/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:02 a.m.
mooli tayer has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1: Code-Review-1
why can't we remove tool call during %postun?
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:34 a.m.
mooli tayer has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1: Code-Review+1
sorry I was confused.
ok I can't think of any way to avoid this.
I'm good with this style - a context manager will not do any real good.
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:53 a.m.
New subject: Change in vdsm[master]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 2:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:53 a.m.
New subject: Change in vdsm[master]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 2:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17443/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:53 a.m.
New subject: Change in vdsm[master]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 2:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17617/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:55 a.m.
New subject: Change in vdsm[master]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17443/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17617/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:37 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:37 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17450/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:37 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17624/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:37 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:39 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17450/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17624/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:25 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Federico Simoncelli has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:51 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
To verify this patch I tested upgrade flow over el6 and el7 and ran few vdsm-tool tests
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Federico Simoncelli has submitted this change and it was merged.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Since oVirt 3.5 (vdsm 4.16) we started to install vdsm site-packages under
/usr/lib (python_sitelib). In sys.path the import order first check
under
/usr/lib64. While upgrading vdsm 3.4 to >=3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1200467
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39410
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified
Federico Simoncelli: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
* Update tracker::#1200467::OK
* Set MODIFIED::bug 1200467::::#1200467::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (1/10) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/843/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (2/10) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_...
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (3/10) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64...
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (4/10) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/814/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (5/10) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64...
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (6/10) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4823/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (7/10) ->
http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_...
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (8/10) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/848/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (9/10) ->
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_...
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:36 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Started (10/10) ->
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/848/
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:55 a.m.
New subject: Change in vdsm[master]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/843/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64... :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4823/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/814/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_... :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/848/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_... :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64... :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/848/ : FAILURE
http://jenkins.ovirt.org/job/sshnaidm_vdsm_master_create-rpms-fc21-ppc64_... :
FAILURE
--
To view, visit https://gerrit.ovirt.org/39410
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3331
days inactive
3336
days old
vdsm-patches@lists.fedorahosted.org
31 comments
5 participants
participants (5)
-
automation＠ovirt.org -
Federico Simoncelli -
Jenkins CI RO -
mtayer＠redhat.com -
ybronhei＠redhat.com