10:12 a.m.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Hack to fix vdsm-tool import issues during upgrade
In oVirt 3.5 we started to install vdsm site-packages under /usr/lib
(python_sitelib). In sys.path the import order first check under
/usr/lib64. While upgrading vdsm 3.4 to 3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade. This will be needed also in ovirt-3.6 if we
want to support upgrade between 3.4 to 3.6.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Label: OVIRT-3.5 ONLY
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/39408/1
diff --git a/vdsm-tool/vdsm-tool b/vdsm-tool/vdsm-tool
index 8fa3bc5..e46bb21 100755
--- a/vdsm-tool/vdsm-tool
+++ b/vdsm-tool/vdsm-tool
@@ -28,8 +28,30 @@
import syslog
import traceback
+########################################################################
+# Ugly hack for 3.5 which switches the use of /usr/lib64 to /usr/lib.
+#
+# To avoid loading vdsm-tool verbs from old location (/usr/lib64)
+# we need to explicit import vdsm.tool from /usr/lib.
+# On upgrade from 3.4-3.5 when this directory change first introduced
+# we load vdsm.tool from /usr/lib64 before 3.4 package got removed.
+#
+# This leads to upgrade errors on vdsm-tool calls. With this ugly fix
+# I first add to path /usr/lib, import and then remove sys.path changes.
+# If I don't remove the changes it leads to other issues when
+# importing seobject.
+########################################################################
+
+sys.path.insert(0, '/usr/lib/python2.6/site-packages')
+sys.path.insert(0, '/usr/lib/python2.7/site-packages')
+
import vdsm.tool
+sys.path.pop(0)
+sys.path.pop(0)
+
+########################################################################
+
tool_modules = []
tool_command = {}
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
10:12 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:20 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:20 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 2: -Verified
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:27 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 3:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:28 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 4:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:28 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:44 p.m.
Oved Ourfali has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:23 p.m.
Nir Soffer has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52:
Line 53: ########################################################################
Line 54:
Nice hack, but did you consider using imp?
import imp
lib = os.path.join(os.path.dirname(os.__file__).replace('lib64',
'lib'), 'site-packages')
vdsm = imp.load_module('vdsm', *imp.find_module('vdsm', [lib]))
vdsm.tool = imp.load_module('vdsm.tool', *imp.find_module('tool',
vdsm.__path__))
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57:
Line 58: ERROR_SAME_COMMAND = """\
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
1:12 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52:
Line 53: ########################################################################
Line 54:
Nice hack, but did you consider using imp?
Yes, but
couldn't find the exact way properly. I'll check that code
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57:
Line 58: ERROR_SAME_COMMAND = """\
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
7:40 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52:
Line 53: ########################################################################
Line 54:
Yes, but couldn't find the exact way properly. I'll check
that code
that way you load all under lib/vdsm .. anyway to avoid that with imp? I
don't find..
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57:
Line 58: ERROR_SAME_COMMAND = """\
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
7:48 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52:
Line 53: ########################################################################
Line 54:
that way you load all under lib/vdsm .. anyway to avoid that with
imp? I do
I'd prefer imp as well if this is not too urgent and we quickly find
an implementation.
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57:
Line 58: ERROR_SAME_COMMAND = """\
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
8:36 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 6: Verified-1
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* Check merged to previous::WARN, Still open on branches master
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:51 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 7: Verified-1
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* Check merged to previous::WARN, Still open on branches master
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9:45 a.m.
Oved Ourfali has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:20 a.m.
Nir Soffer has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/39408/5/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 50: sys.path.pop(0)
Line 51: sys.path.pop(0)
Line 52:
Line 53: ########################################################################
Line 54:
that way you load all under lib/vdsm .. anyway to avoid that with
imp? I do
With imp, you will have to import all the modules manually, or write a
helper
for loading nested modules (e.g, a.b.c).
For example, to load a.b.c - you need to:
- load a
- load b and set a.b
- load c and set a.b.c
I don't think that we want to go so far. Importing one module to avoid temporary
issue on upgrade is ok.
Line 55: tool_modules = []
Line 56: tool_command = {}
Line 57:
Line 58: ERROR_SAME_COMMAND = """\
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
10:34 a.m.
Nir Soffer has posted comments on this change.
Change subject: Hack to fix vdsm-tool import issues during upgrade
......................................................................
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/39408/7/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 35: # all tool's verbs are loaded from the old vdsm code.
Line 36: ########################################################################
Line 37: import imp
Line 38: vdsm_libdir = [os.path.join(os.path.dirname(os.__file__).
Line 39: replace('lib64', 'lib'), 'site-packages')
+ '/vdsm']
Add 'vdsm' at the end:
os.path.join(..., 'site-packages', 'vdsm')
Line 40: tool = imp.load_module('vdsm.tool',
Line 41: *imp.find_module('tool', vdsm_libdir))
Line 42: ########################################################################
Line 43:
Line 37: import imp
Line 38: vdsm_libdir = [os.path.join(os.path.dirname(os.__file__).
Line 39: replace('lib64', 'lib'), 'site-packages')
+ '/vdsm']
Line 40: tool = imp.load_module('vdsm.tool',
Line 41: *imp.find_module('tool', vdsm_libdir))
This does not match the behavior of regular imports - when you do
"import vdsm.tool" - the system will import both vdsm and tool, and set
vdsm.tool. This is the reason I suggested to import both vdsm and tool.
Please check what happens when modules under vdsm/tool/ are importing
stuff from vdsm - for example:
from vdsm import utils
It is possible that the modules will get old utils from /usr/lib64/ and we
will have a horrible mess.
Hopefully, if you did import vdsm from /usr/lib, when other modules import
stuff from vdsm they will use vdsm.__file__ to locate the other modules,
and will get them also from /usr/lib.
To debug this, run the tool with python -v, and check that all the imports are
expected.
Line 42: ########################################################################
Line 43:
Line 44: tool_modules = []
Line 45: tool_command = {}
Line 79: """
Line 80: global tool_modules, tool_command
Line 81:
Line 82: mod_path = os.path.dirname(tool.__file__)
Line 83: package_name = tool.__name__
Importing vdsm.tool will avoid these changes and will keep this patch smaller.
Line 84:
Line 85: for mod_name in _listPathModules(mod_path):
Line 86: if mod_name.startswith("_"):
Line 87: continue
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
8 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 8: Verified-1
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* Check merged to previous::WARN, Still open on branches master
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:04 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
Nir Soffer has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8:48 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 8:
for now I plan to merge it only to ovirt-3.5 for next build
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-HasComments: No
10:26 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
Federico Simoncelli has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 8: Code-Review+2
Committing this only to ovirt-3.5 means that we are breaking upgrade from 3.4 to 3.6.
Anyway we support only 1 version upgrade (3.4 => 3.5 => 3.6) and this is a little
hacky, so I'm fine with an ovirt-3.5-only patch.
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-HasComments: No
10:32 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
Yaniv Bronhaim has posted comments on this change.
Change subject: Hack vdsm 4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-HasComments: No
10:35 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 9: Verified-1
* Update tracker::#1200467::OK
* Check Bug-Url::OK
* Check Public Bug::#1200467::OK, public bug
* Check Product::#1200467::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1200467::OK, correct target release 3.5.3
* Check merged to previous::WARN, Still open on branches master
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:38 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Federico Simoncelli has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 9:
After speaking with Yaniv we agreed that it's probably better to take this to master
as well. He'll try to verify that it's working fine in all scenarios.
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
11:42 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Nir Soffer has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 9:
I agree, 3.5 only patches makes our life harder. We can also revert it on master if
needed.
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
4:29 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 10:
* Update tracker::#1208752::OK
* Check Bug-Url::OK
* Check Public Bug::#1208752::OK, public bug
* Check Product::#1208752::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1208752::OK, correct target release 3.5.1
* Check merged to previous::WARN, Still open on branches master
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
Since oVirt 3.5 (vdsm 4.16) we started to install vdsm site-packages under
/usr/lib (python_sitelib). In sys.path the import order first check
under
/usr/lib64. While upgrading vdsm 3.4 to >=3.5 we perform configure call in
%postun which calls vdsm-tool, vdsm-tool tries to import vdsm.tool which
exists both under /usr/lib and under /usr/lib64 in this specific case
before all vdsm 3.4 files were removed. In such case we get failures all
over.
This patch hacks the import part and takes care of importing vdsm.tool
from the /usr/lib on upgrade.
Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1208752
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39408
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm-tool/vdsm-tool
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Verified
Federico Simoncelli: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
automation(a)ovirt.org has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
* Update tracker::#1208752::OK
* Set MODIFIED::bug 1208752::::#1208752::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
Build Started (1/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/30/
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
Build Started (2/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/205/
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
Build Started (3/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/199/
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:56 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
Build Started (4/4) ->
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/206/
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:44 a.m.
New subject: Change in vdsm[ovirt-3.5]: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Hack vdsm >=4.16.x for vdsm-tool import issues during upgrade
......................................................................
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/205/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/30/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/206/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/199/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/39408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3331
days inactive
3336
days old
vdsm-patches@lists.fedorahosted.org
32 comments
6 participants
participants (6)
-
automation＠ovirt.org -
Federico Simoncelli -
Jenkins CI RO -
Nir Soffer -
Oved Ourfali -
ybronhei＠redhat.com