Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32057
to review the following change.
Change subject: tool: Fix another Python 2.6 compatibility issue
......................................................................
tool: Fix another Python 2.6 compatibility issue
Commit 096cc03d2f replaced the configurators tuple with a dict, using
dict comprehension syntax, which is not available on Python 2.6. Now we
use the good old dict() syntax instead.
We also silence a pep8-1.4.5 complaint.
Change-Id: Iee6e473d268317f7cdc42022a7a645e5eaee3a26
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/31738
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 5 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/32057/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 6130d56..268ae46 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -34,13 +34,11 @@
def _getConfigurers():
- return {
- m.getName(): m for m in (
- certificates.Certificates(),
- libvirt.Libvirt(),
- sanlock.Sanlock(),
- )
- }
+ return dict((m.getName(), m) for m in (
+ certificates.Certificates(),
+ libvirt.Libvirt(),
+ sanlock.Sanlock(),
+ ))
@expose("configure")
--
To view, visit
http://gerrit.ovirt.org/32057
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6e473d268317f7cdc42022a7a645e5eaee3a26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>